[Fix] - Linter Issues, Formatting, Upgraded Deps #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mrz1836
commented
Sep 29, 2025
mrz1836
commented
- Cleaned up GitHub workflows and action files by removing trailing blank lines and extra spaces for better consistency and readability.
- Reordered and reformatted devcontainer.json for improved structure and alignment with best practices.
- Removed redundant comments and added helpful guidance in CodeQL workflow for improved maintainability.
- Updated protobuf dependency to version v1.36.9 to include latest fixes and ensure compatibility.
- Refactored SwissLockFreeMapUint64 Put method and tests to simplify method signature and improve code clarity.
Remove trailing blank lines and extra spaces across GitHub workflow and action YAML files to maintain consistency and improve readability. This cleanup applies to CodeQL analysis, issue templates, the warm-cache action, and auto-merge workflows. It helps enforce style consistency without changing any logic or behavior.
Remove unnecessary trailing blank lines from fortress-test-suite.yml and fortress-benchmarks.yml to improve readability and maintain a consistent style across CI workflow files. This helps keep the CI configuration tidy without altering any functionality.
Rearrange devcontainer.json fields for improved readability and maintain existing configuration including image, features, mounts, runArgs, and VSCode customizations. This change does not affect functionality but standardizes formatting and structure to align with best practices. chore(ci): cleanup trailing blank lines in config files Remove unnecessary trailing blank lines in dependabot.yml, codecov.yml, .gitpod.yml, and GitHub workflow sync-labels.yml for consistent formatting across configuration files and to adhere to style guidelines.
Remove redundant comment lines from the Autobuild step to improve workflow readability. Add helpful comments to the CodeQL analysis step to provide guidance on command usage for future maintenance.
Bump google.golang.org/protobuf from v1.36.6 to v1.36.9 to incorporate latest fixes and improvements. This update ensures compatibility with newer tooling and resolves potential issues present in the previous version.
Simplify Put method signature by combining parameters for clarity. Update iteration callback in tests to use blank identifiers where arguments are unused, improving readability. Add minor formatting adjustments in tests for consistency. These changes improve code clarity and maintainability without altering functionality.
github-actions
bot
added
bug-P3
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses code quality improvements by fixing linter issues, updating formatting configurations, upgrading dependencies, and refactoring function signatures for better clarity. The changes focus on consistency across GitHub workflows and configuration files while maintaining functionality.
- Cleaned up trailing blank lines and formatting across GitHub workflows, configuration files, and devcontainer setup
- Updated protobuf dependency from v1.36.6 to v1.36.9 for latest fixes and compatibility
- Refactored SwissLockFreeMapUint64 Put method signature and test parameter names for improved readability
Reviewed Changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tx_map_test.go | Updated test to use blank identifiers for unused parameters and added spacing |
| tx_map.go | Simplified Put method signature by combining parameters of same type |
| go.mod | Upgraded protobuf dependency to v1.36.9 |
| Multiple workflow files | Removed trailing blank lines for consistent formatting |
| .devcontainer.json | Reorganized JSON structure for better readability |
| .golangci.json | Reordered configuration sections and improved formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.