generated from bitcoin-sv/template
-
Notifications
You must be signed in to change notification settings - Fork 8
Develop port #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
F1r3Hydr4nt
wants to merge
154
commits into
master
Choose a base branch
from
develop-port
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Develop port #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption, master_certificate, peer_session, requested_certificate_set, verifiable_certificate) and remove sys.path hack in keys
…bump version to 1.0.8
…port Feature/auth/certificates port
… primitives (AES-CBC/GCM, legacy helpers)
… decrypt) compatible with Go ECIES
…llet integration and callbacks\n\n- Closes #55, #54, #53, #52, #51, #50, #49, #48\n- Implement session manager + helpers and re-export PeerSession\n- Handshake (nonce-based), general message sign/verify, cert req/resp\n- Integrate wallet interface for HMAC/sign/verify + encryption hooks\n- Callback registration APIs and safer invocation (snapshot)\n- Reduce cognitive complexity and add defensive checks\n- Best-effort stop() and secure_send() delegate
Feature/auth/certificates port
Refactor SimplifiedHTTPTransport: improve error handling and payload …
fix(utils): Update utils module with latest changes and absolute imports
feat(auth/clients): Add and update client modules under auth/clients
feat(auth/transports): Add and update modules under auth/transports
…d update all imports
Feature/auth/certificates port
…p implementations
refactor(chaintrackers): update imports to absolute paths and clean u…
chore(registry): translate comments to English and clean up code
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…rough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
- Create CodeQL configuration to exclude tests/** paths - Disable security queries for test files and debug code - Add CodeQL workflow with custom config - Keeps security scanning for production code only
…rough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
- Remove .github/codeql/codeql-config.yml - Remove .github/workflows/codeql.yml - Use GitHub's default CodeQL setup instead
- Use exact dictionary key check instead of 'in' operator for peers - Use startswith() for URL validation to avoid substring issues - Addresses CodeQL incomplete URL substring sanitization alerts
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Resolved conflicts: - .gitignore: Merged both versions (kept .wallet, .venv/, .env*) - bsv/__init__.py: Updated version to 1.0.10 - bsv/fee_models/live_policy.py: Accepted master's superior implementation - Made current_rate_sat_per_kb() private (_current_rate_sat_per_kb) - Aligns with TS/Go SDK design where only compute_fee() is public - Thread-safe caching, better error handling, logging, configurable HTTP client - bsv/script/script.py: Accepted master's BRC-106 compliant implementation - bsv/transaction.py: Accepted master's improved fee calculation with async support - tests: Updated test_live_policy.py to only test public compute_fee() API - tests/bsv/broadcasters/test_broadcaster_arc_ef_or_rawhex.py: Accepted master's pytest version All conflicts resolved. Tests updated to align with private API design.
- Fixed test_cache_expiry to use await asyncio.sleep() instead of time.sleep() - Proper async/await usage in async test function
Replace inaccessible commit SHA with v9 version tag for better reliability
- Update tests/test_live_policy.py to use private _current_rate_sat_per_kb() method - Fix test_transaction_fee_with_default_rate to use synchronous SatoshisPerKilobyte instead of async LivePolicy default - Update test_get_public_key_with_debug_enabled to check for redacted debug output format All previously failing tests now pass.
Use commit SHA 61a88be553afe4206585b31aa72d388864cbe0d5 (v9.1.4) instead of version tag for better security and reliability
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description of Changes
Provide a brief description of the changes you've made.
Linked Issues / Tickets
Reference any related issues or tickets, e.g. "Closes #123".
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist:
CHANGELOG.mdwith my changes