Feature/add whatsonchain tests #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
WoC Broadcaster Network Param #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added tests for WhatsOnChain classes to verify Network enum support and string backward compatibility. The tests cover both WhatsOnChainBroadcaster and WhatsOnChainTracker classes, ensuring proper initialization with both Network enum and string parameters.
Linked Issues / Tickets
Related to the requirement to use Network enum for network parameters instead of string literals.
Testing Procedure
Added comprehensive test cases for:
Network enum initialization (MAINNET/TESTNET)
String network parameter backward compatibility (main/test/mainnet/testnet)
Invalid network parameter validation
URL construction validation for both broadcasters and trackers
I have added new unit tests
All tests pass locally
I have tested manually in my local environment
Checklist:
CHANGELOG.mdwith my changesNote: Documentation and CHANGELOG updates are not checked as this PR only adds tests for future implementation of Network enum support.