Feature/optimize tx preimage calculation #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default fee rate was hardcoded to 10 satoshis per kilobyte. This update allows users to configure the default fee rate via the TRANSACTION_FEE_RATE variable in constants.py or through the environment file. A test for the default fee rate has also been added.
- Refactored tx_preimage function to directly calculate preimage for a single input - Eliminated redundant calculations from tx_preimages function - Improved clarity of sighash flag handling This change improves performance for single-input signing scenarios by avoiding unnecessary preimage calculations for inputs that won't be signed.
Collaborator
|
This pull request introduces several improvements and fixes. |
voyager1708
approved these changes
Mar 26, 2025
Collaborator
voyager1708
left a comment
voyager1708
left a comment
There was a problem hiding this comment.
This pull request introduces several improvements and fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Optimized transaction preimage calculation by refactoring the tx_preimage function to directly compute the preimage for a specified input, avoiding unnecessary computation for all inputs
Achieved a 3× performance improvement in scenarios with 250 inputs, based on benchmarking
Checklist:
CHANGELOG.mdwith my changes