Skip to content

Conversation

@jo7ueb
Copy link
Collaborator

@jo7ueb jo7ueb commented Aug 13, 2025

Description of Changes

Wrote release notes

Linked Issues / Tickets

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I have run the linter

@jo7ueb jo7ueb requested review from ALiberalVoluntarist and Copilot and removed request for ALiberalVoluntarist August 13, 2025 02:45

This comment was marked as outdated.

@jo7ueb
Copy link
Collaborator Author

jo7ueb commented Aug 13, 2025

The “Security Hotsopt” pointed out is not accurate.
The ‘1.0.7.2’ described in __init.py is a version number, not an IP address, and does not pose a security issue.

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jo7ueb jo7ueb requested a review from Copilot August 13, 2025 03:10

This comment was marked as outdated.

@sonarqubecloud
Copy link

@jo7ueb jo7ueb requested a review from Copilot August 13, 2025 03:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the package version to 1.0.8 and adds corresponding release notes documenting security vulnerability fixes.

  • Updated version number from 1.0.7.1 to 1.0.8 in package metadata
  • Added changelog entry for version 1.0.8 with security vulnerability mitigation details

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
bsv/init.py Updates package version string to 1.0.8
CHANGELOG.md Adds release notes for version 1.0.8 with security fix documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.



__version__ = '1.0.7.1'
__version__ = '1.0.8'
Copy link

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version mismatch detected. The PR title indicates version 1.0.7.2, but the code sets version to 1.0.8. These should be consistent.

Suggested change
__version__ = '1.0.8'
__version__ = '1.0.7.2'

Copilot uses AI. Check for mistakes.
@jo7ueb jo7ueb changed the title add release note and set version to 1.0.7.2 add release note and set version to 1.0.8 Aug 13, 2025
@jo7ueb
Copy link
Collaborator Author

jo7ueb commented Aug 13, 2025

I changed version number to 1.0.8.
This change is independent from changes introduced in version 1.0.7.
So I assigned different minor version code.

Copy link
Collaborator

@ALiberalVoluntarist ALiberalVoluntarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ALiberalVoluntarist ALiberalVoluntarist merged commit 0d650e3 into bsv-blockchain:master Aug 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants