Skip to content

Conversation

@oskarszoon
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

🤖 Claude Code Review

Status: Complete


Current Review:

No critical issues found. The PR addresses timeout issues during checkpoint syncs by limiting block batch sizes to 10,000 blocks when the header list is large.

Changes:

  • services/legacy/netsync/manager.go: Adds logic to cap batch requests at 10k blocks when headerListLen > 10k to avoid peer processing timeouts during large checkpoint gaps
  • services/utxopersister/filestorer/FileStorer.go: Changes log level from Info to Debug for buffer size message (reduces log noise)
  • settings.conf: Adds legacy_peerProcessingTimeout = 10m configuration option

The implementation is straightforward and addresses the stated problem. The hardcoded 10,000 limit is reasonable given the context (large checkpoint gaps causing timeouts), and the logging provides visibility into when the limit is applied.

@oskarszoon oskarszoon merged commit 1c1fd8e into bsv-blockchain:main Nov 25, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants