Skip to content

UTF8 strings instead of Base64 bytes for InternalizeAction prefix/suffix #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

UTF8 strings instead of Base64 bytes for InternalizeAction prefix/suffix #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc6b38
Use UTF8 strings instead of Base64 bytes for InternalizeAction prefix…
jchavannes Sep 17, 2025
b35bfd1
Update prefix/suffix type def
jchavannes Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/wallet/Wallet.interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,13 +500,13 @@ export interface ListActionsResult {
}

/**
* @param {Base64String} derivationPrefix - Payment-level derivation prefix used by the sender for key derivation (for payments).
* @param {Base64String} derivationSuffix - Specific output-level derivation suffix used by the sender for key derivation (for payments).
* @param {string} derivationPrefix - Payment-level derivation prefix used by the sender for key derivation (for payments).
* @param {string} derivationSuffix - Specific output-level derivation suffix used by the sender for key derivation (for payments).
* @param {PubKeyHex} senderIdentityKey - Public identity key of the sender (for payments).
*/
export interface WalletPayment {
derivationPrefix: Base64String
derivationSuffix: Base64String
derivationPrefix: string
derivationSuffix: string
senderIdentityKey: PubKeyHex
}

Expand Down
4 changes: 2 additions & 2 deletions src/wallet/substrates/WalletWireProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ export default class WalletWireProcessor implements WalletWire {
const derivationPrefixBytes = paramsReader.read(
derivationPrefixLength
)
output.paymentRemittance.derivationPrefix = Utils.toBase64(
output.paymentRemittance.derivationPrefix = Utils.toUTF8(
derivationPrefixBytes
)

Expand All @@ -828,7 +828,7 @@ export default class WalletWireProcessor implements WalletWire {
const derivationSuffixBytes = paramsReader.read(
derivationSuffixLength
)
output.paymentRemittance.derivationSuffix = Utils.toBase64(
output.paymentRemittance.derivationSuffix = Utils.toUTF8(
derivationSuffixBytes
)
} else if (protocolFlag === 2) {
Expand Down
4 changes: 2 additions & 2 deletions src/wallet/substrates/WalletWireTransceiver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,13 +843,13 @@ export default class WalletWireTransceiver implements WalletInterface {
)
const derivationPrefixAsArray = Utils.toArray(
out.paymentRemittance.derivationPrefix,
'base64'
'utf8'
)
paramWriter.writeVarIntNum(derivationPrefixAsArray.length)
paramWriter.write(derivationPrefixAsArray)
const derivationSuffixAsArray = Utils.toArray(
out.paymentRemittance.derivationSuffix,
'base64'
'utf8'
)
paramWriter.writeVarIntNum(derivationSuffixAsArray.length)
paramWriter.write(derivationSuffixAsArray)
Expand Down