fix: correct node sdk package name #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the import from '@bucketeer/node-server-sdk' to use multi-line formatting for improved readability and consistency.
duyhungtnn
force-pushed
the
fix/correct-node-server-sdk-package
branch
from
22e1475 to
7dda281
Compare
Copilot finished reviewing on behalf of
duyhungtnn
November 19, 2025 03:35
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the SDK dependency from bkt-node-server-sdk to the new scoped package @bucketeer/node-server-sdk, standardizing the SDK import across the codebase. The migration also includes dependency version updates, stricter linting enforcement, and improved test coverage for version validation.
- Updates all SDK imports from
bkt-node-server-sdkto@bucketeer/node-server-sdk - Enforces zero warnings in the lint script via
--max-warnings=0 - Adds test validation to ensure
SDK_VERSIONis defined
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates SDK package name in dependencies and peerDependencies; enforces stricter linting; moves @openfeature/core from peer to devDependencies |
| yarn.lock | Reflects the package migration from bkt-node-server-sdk to @bucketeer/node-server-sdk and updates related dependencies |
| src/index.ts | Updates export statement to use new SDK package name |
| src/internal/BucketeerProvider.ts | Updates SDK import and removes unused imports (ErrorCode, StandardResolutionReasons) |
| src/internal/BKTEvaluationDetailExt.ts | Updates SDK import to new package name |
| src/internal/EvaluationContext.ts | Updates SDK import to new package name |
| test/BucketeerProvider.test.ts | Updates all SDK imports and mock paths to new package name |
| test/BKTEvaluationDetailExt.test.ts | Updates SDK import to new package name |
| e2e/localEvaluate.test.ts | Adds assertion to verify SDK_VERSION is defined before checking version equality |
| .prettierignore | Adds CHANGELOG.md to ignored files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
duyhungtnn
changed the title
Bumped the @bucketeer/node-server-sdk devDependency from version 0.4.2 to 0.4.3 for latest fixes and improvements.
Clarifies the installation command to include required peer dependencies and updates the note about peer dependencies for better guidance.
cre8ivejp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the SDK dependency from
bkt-node-server-sdkto@bucketeer/node-server-sdkthroughout the codebase and test files. It also makes improvements to linting and ensures that the SDK version is properly checked in tests. These changes help standardize the SDK import, improve code quality, and ensure version consistency.SDK dependency migration:
All imports of
bkt-node-server-sdkhave been replaced with@bucketeer/node-server-sdkin source filesThe
package.jsondependencies and peerDependencies have been updated to use@bucketeer/node-server-sdkinstead ofbkt-node-server-sdk.Linting and code quality:
lintscript inpackage.jsonnow uses--max-warnings=0to enforce stricter linting.Testing improvements:
SDK_VERSIONis defined, ensuring version consistency between the provider and the SDK.