Feature/windows support #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- path manipulation and comparison operations were assuming posix-style paths. Adds a bit of normalization so that paths on Windows are always converted to use forward-slashes. This is fine because Windows treats both as path delimeters and forward slashes are not valid in directory or file names.
|
The decrease in code coverage is because there's an if-else block that runs one statement on Windows, the other on Linux and Mac. |
|
@cspotcode I wanted to do this for so long. But never got time for it. 🎉 |
|
This should actually fix some other issues in typescript hero! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for running on Windows. Some path-related operations were assuming a posix OS. Now paths are always normalized to Posix-style forward-slash delimiters. Windows will accept both slashes as a delimiter and does not allow forward slashes in file or directory names, so this should be safe and predictable to users.