Skip to content

Conversation

@bufdev
Copy link
Member

@bufdev bufdev commented Aug 14, 2025

  • Update CI/Makefile to Go 1.25.0.
  • Update buf to v1.56.0.
  • Default to empty for two Makefile environment variables PKG and HOST_TARGET that were producing warnings.
  • Remove extra whitespace in Makefile.
  • make upgrade
  • Re-run make generate, which was actually the original reason for this PR. Bump actions/checkout from 4 to 5 #21 failed because the build is non-deterministic due to not pinning the remote plugin versions in buf.gen.yaml and buf.gen.vt.yaml. I'd argue we keep them unpinned and always use latest, but an argument could go both ways.
  • Rename buf.gen.vt.yaml to buf.vt.gen.yaml - .gen.yaml is the effective extension.

Signed-off-by: bufdev <bufdev-github@buf.build>
@bufdev bufdev requested a review from mcy August 14, 2025 15:59
@github-actions
Copy link

github-actions bot commented Aug 14, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedAug 18, 2025, 8:35 PM

@doriable
Copy link
Member

Upgraded golangci-lint to 2.4.0 for go 1.25 support. Updated the config with the following, open to different decisions:

  • disabled embeddedstructfieldcheck since our struct fields are deliberately structured for minimizing padding
  • disabled noinlineerr since this is an established pattern that we use
  • disabled wsl_v5 along with already disabled wsl
  • added some exceptions for the use of exec.Command in hyperdump and hypertest tools

mcy
mcy previously approved these changes Aug 18, 2025
os: [ubuntu-latest, macos-15]
mode: [fast, debug, race]
go-version: [1.24.x]
go-version: [1.25.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge this unless we run tests for both 1.24 still. Would you mind including both in the matrix? We can remove the 1.24 version later.

@doriable doriable changed the title Cleanup Cleanup Makefile and update versions Aug 18, 2025
@mcy mcy merged commit f948723 into main Aug 18, 2025
18 of 19 checks passed
@mcy mcy deleted the cleanup branch August 18, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants