Add swift v1.22.0 with updated patch #574
Conversation
Update the patch to cleanly apply against apple/swift v1.22.0.
| @@ -0,0 +1,58 @@ | |||
| diff --git a/Sources/protoc-gen-swift/FileGenerator.swift b/Sources/protoc-gen-swift/FileGenerator.swift | |||
There was a problem hiding this comment.
Updated the patch to apply cleanly on this version - there were some changes upstream in apple/swift-protobuf@6b33e90 that caused the previous patch not to apply.
@pgmitche / @stefanvanburen / @rebello95 - I'm not sure if we want to do anything here with the new visibilityAnnotation logic?
There was a problem hiding this comment.
The patch looks essentially identical, so happy to approve on that basis.
If I'm understanding the annotation correctly, then it sounds like symbols in the packages generated with that annotation would not be importable, so wouldn't be compatible with remote packages.
There was a problem hiding this comment.
Don't think we need to do anything for that new option, we don't have a use case for implementation-only imports with remote packages. Also updating Connect-Swift: connectrpc/connect-swift#136
Update the patch to cleanly apply against apple/swift v1.22.0.