Skip to content

Fix descriptor pool TODO #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Fix descriptor pool TODO #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions test/conformance/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
from google.protobuf import any_pb2, descriptor, descriptor_pool, message_factory

import protovalidate

# TODO(afuller): Use dynamic descriptor pool based on the FileDescriptorSet
# in the TestConformanceRequest, once the Python protobuf library no longer
# segfaults when using a dynamic descriptor pool.
from buf.validate.conformance.cases import (
bool_pb2, # noqa: F401
bytes_pb2, # noqa: F401
Expand Down Expand Up @@ -93,10 +89,9 @@ def run_any_test_case(
def run_conformance_test(
request: harness_pb2.TestConformanceRequest,
) -> harness_pb2.TestConformanceResponse:
# pool = descriptor_pool.DescriptorPool()
# for fd in request.fdset.file:
# pool.Add(fd)
pool = descriptor_pool.Default()
pool = descriptor_pool.DescriptorPool()
for fd in request.fdset.file:
pool.Add(fd)
result = harness_pb2.TestConformanceResponse()
for name, tc in request.cases.items():
run_any_test_case(pool, tc, result.results[name])
Expand Down