Skip to content

Conversation

@stefanvanburen
Copy link
Member

  • Use absolute instead of relative link for Buf logo, so it displays elsewhere (e.g. PyPI: https://pypi.org/project/protovalidate/)
  • Use img.shields.io for version shield for consistency with other projects

* Use absolute instead of relative link for Buf logo, so it displays
  elsewhere (e.g. PyPI: https://pypi.org/project/protovalidate/)
* Use img.shields.io for version shield for consistency with other
  projects
[![CI](https://github.com/bufbuild/protovalidate-python/actions/workflows/ci.yaml/badge.svg)](https://github.com/bufbuild/protovalidate-python/actions/workflows/ci.yaml)
[![Conformance](https://github.com/bufbuild/protovalidate-python/actions/workflows/conformance.yaml/badge.svg)](https://github.com/bufbuild/protovalidate-python/actions/workflows/conformance.yaml)
[![PyPI version](https://badge.fury.io/py/protovalidate.svg)](https://badge.fury.io/py/protovalidate)
[![PyPI version](https://img.shields.io/pypi/v/protovalidate)](https://pypi.org/project/protovalidate)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I check https://img.shields.io/pypi/v/protovalidate, the image is orange. https://badge.fury.io/py/protovalidate.svg is green.

Does that indicate a problem/warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://shields.io/badges/py-pi-version, I don't think so; we can change the color= querystring parameter if it matters much?

I tend to look at attrs for guidance here as an established pypi project, and they seemingly have it blue, with the default value. I wonder if it's just because we're pre-1.0, or because we haven't set up trusted publishing yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to use the default — I just wanted to make sure the change wasn't indicative of a problem. Nothing 404s, I'll approve this just now.

@stefanvanburen stefanvanburen merged commit ef083bc into main Jul 31, 2025
13 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/readme branch July 31, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants