Pin local Python version to lowest supported #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just helps to ensure when developing that we're targeting the lowest supported version, otherwise it'll only be caught in CI.
|
(Checked that tests are still running with their configured versions: https://github.com/bufbuild/protovalidate-python/actions/runs/16998905451/job/48196215492?pr=351#step:5:107) |
rodaine
approved these changes
Aug 18, 2025
stefanvanburen
added a commit
that referenced
this pull request
Sep 25, 2025
This reverts commit 0aedc8c. Checked again and this _should_ be superfluous. Removing for now.
stefanvanburen
added a commit
that referenced
this pull request
Sep 25, 2025
stefanvanburen
added a commit
that referenced
this pull request
Oct 8, 2025
This reverts commit fb15875. When working through #384 without a pin set, running `make` would default to Python 3.13 locally. (Not sure if this is a `uv` version thing, or what.) I think it's best to keep this pinned in Python libraries to the lowest supported Python version to avoid confusion, especially since we don't specify a `uv` version to use (for now).
stefanvanburen
added a commit
that referenced
this pull request
Oct 8, 2025
This reverts commit fb15875. When working through #384 without a pin set, running `make` would default to Python 3.13 locally. (Not sure if this is a `uv` version thing, or what.) I think it's best to keep this pinned in Python libraries to the lowest supported Python version to avoid confusion, especially since we don't specify a `uv` version to use (for now).
stefanvanburen
added a commit
that referenced
this pull request
Oct 9, 2025
…385) This reverts commit fb15875. When working through #384 without a pin set, running `make` would default to Python 3.13 locally. (Not sure if this is a `uv` version thing, or what.) I think it's best to keep this pinned in Python libraries to the lowest supported Python version to avoid confusion, especially since we don't specify a `uv` version to use (for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just helps to ensure when developing that we're targeting the lowest supported version, otherwise it'll only be caught in CI.
Ref: https://docs.astral.sh/uv/concepts/python-versions/#python-version-files