Remove collect_violations(..., into=) argument #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings us full circle, effectively backing out #323. Resolves #362. [1]: https://docs.python.org/3/tutorial/controlflow.html#keyword-only-arguments
At risk of Chesterton's fencing myself, but I don't think this argument is needed or ever used (other than in tests). I can't think of a reason why someone would want to shove multiple validations into the same validation, instead of simply calling `collect_violations` multiple times and combining the lists afterwards. I did some `git blame` spelunking and it looks like this originally turned up in #32, but didn't see much reasoning for it in that PR. The PR mentioned both Pydantic and making things closer to protovalidate-go's API, but neither seem to have a similar style of reusing a returned error/exception like this. Stacked on #364 as these both munge with the exported API & docstrings; will tag a `v0.15.0` release once all of this is merged.
rodaine
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At risk of Chesterton's fencing myself, but I don't think this argument is needed or ever used (other than in tests). I can't think of a reason why someone would want to shove multiple validations into the same validation, instead of simply calling
collect_violationsmultiple times and combining the lists afterwards.I did some
git blamespelunking and it looks like this originally turned up in #32, but didn't see much reasoning for it in that PR. The PR mentioned both Pydantic and making things closer to protovalidate-go's API, but neither seem to have a similar style of reusing a returned error/exception like this.Stacked on #364 as these both munge with the exported API & docstrings; will tag a
v0.15.0release once all of this is merged.