Remove deprecated label access #371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using FieldDescriptor.label is [now deprecated][1], with some new properties to replace these usages. Unfortunately, the [new types aren't in typeshed yet][2], so we have to ignore the types until the properties are released upstream. [1]: protocolbuffers/protobuf@64a76e6 [2]: python/typeshed#14702
Member
Author
|
ah, nevermind. these won't work with our earliest supported version of |
stefanvanburen
added a commit
that referenced
this pull request
Sep 12, 2025
We'll still test with highest (i.e., newest) dependencies in CI, but to avoid thinking things like #371 will work.
stefanvanburen
added a commit
that referenced
this pull request
Sep 12, 2025
We'll still test with highest (i.e., newest) dependencies in CI, but to avoid thinking things like #371 will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using FieldDescriptor.label is now deprecated, with some new properties to replace these usages.
Unfortunately, the new types aren't in typeshed yet, so we have to ignore the types until the properties are released upstream.