Updating link for feature requests #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@karelm I think this package is totally deprecated now – not used by any app. |
Contributor
Author
|
Thanks @hamstu I had some old logs that showed the output from this package .. so thought it was still being used 😅 thanks for highlighting this 🙌 |
Contributor
Author
|
I think this package is still being used in publish: https://github.com/bufferapp/buffer-publish/blob/7242cb66a098b5c601d3c17cd2b553c514edecdd/packages/sidebar/components/Sidebar/index.jsx#L5 |
Contributor
|
@karelm Yeah we do still have the presentational component there, but we only use it for it's middleware / reducer, and it's never rendered. I think there's a backlogged item to clean that up in Jira, but I'd have to double check. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating link for feature requests to point to new location