fix(ci): add explicit permissions to GitHub Actions workflows #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add permissions blocks to all jobs in CI and release workflows to follow security best practices. This limits GITHUB_TOKEN permissions to minimum required for each job: - contents: read - for jobs that only need to read repository - actions: write - for jobs that upload artifacts (coverage, build) - contents: write - for release job that creates GitHub releases This prevents potential privilege escalation and follows the principle of least privilege for GitHub Actions. Fixes 9 CodeQL security scanning alerts.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 25 25
Lines 3887 3887
=======================================
Hits 3548 3548
Misses 339 339
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit permissions blocks to all GitHub Actions workflow jobs to follow security best practices and fix CodeQL security scanning alerts.
Changes
Security Impact
This change implements the principle of least privilege for GITHUB_TOKEN by explicitly limiting permissions to minimum required for each job:
contents: read- for jobs that only need to read repository contentactions: write- for jobs that upload artifacts (coverage, build)contents: write- for release job that creates GitHub releasesThis prevents potential privilege escalation and improves overall workflow security posture.
Fixes
Resolves 9 CodeQL security scanning alerts:
.github/workflows/ci.yml.github/workflows/release.ymlTesting
References