Linting, formatting and error wrappers#45
Linting, formatting and error wrappers#45bugfest merged 5 commits intobugfest:masterfrom lexfrei:master
Conversation
Signed-off-by: Aleksey Sviridkin <a.sviridkin@sdventures.com>
|
It looks like the |
Signed-off-by: Aleksey Sviridkin <a.sviridkin@sdventures.com>
|
Looks like there are a lot of commented code lines. Do you need them as notes or should they be removed? |
|
Thanks @lexfrei ! Quite a job here. I do agree to drop commented lines of code if I spot anything interesting that otherwise I forget I'll put a comment |
Signed-off-by: Aleksey Sviridkin <a.sviridkin@sdventures.com>
Signed-off-by: Aleksey Sviridkin <a.sviridkin@sdventures.com>
Signed-off-by: Aleksey Sviridkin <a.sviridkin@sdventures.com>
|
For now, I think, the main cleanup is done. There are a lot of possible improvements, but the biggest part of simple changes is done. In this work, I used this golangci-lint config. |
Thanks for the suggestion @lexfrei - I've opened #46 track/implement the action. Will run the build and merge when it finshes. Thanks for all this work!! |
Small improvements:
fmtremoved where possiblegithub.com/cockroachdb/errorsused as a replacement for deprecated "std"errors