bmo sync - 2020-08-23 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properly due to CSP protections
The callback jwt_claims is called in list context. Without an explicit return, when the if (!...) does not match it will return a single false item. This causes the "Odd number of elements..." perl warning. Adding a `return` will prevent the warning and is also probably the intent of the code.
Font preloading has been broken for more than a year, and doesn't appear to work correctly even when provided URLs which exist; removed. google-analytics likely does little to improve page load time performance against all the other assets, is loaded async, and exists outside of the GoogleAnalytics making it easy to miss when updating that extension (eg. the preloading doesn't honour DNT); also removed.
… or Toolkit does not cause the textbox for user information to pop up
…ars other (review, ui-review) flags
* Start WIP PR * Modify default need info text * Fix breaking bugwords.t * You have to fix all the instances of the word. * Adding conditional for needinfo to reporter * fix failing bugwords.t again * Don't divert people with questions to bmo team * don't repeat bug url * fix terms.bug * Remove 'to see question,' question is in email * Keep the link to the bug * move text into a conditional branch * link to needinfo docs
…iOS bug reports (#1600) * Move all the products to the product template * Link mobile products to GitHub * Better boilerplate text * Fix failing terms test
* 'master' of https://github.com/mozilla-bteam/bmo: Bug 1655808: send users in guided bug flow to GitHub for Android and iOS bug reports (#1600) Bug 1654370 - Remove remaining code that references Firefox OS from BMO code base Bug 1654456 - needinfo? request email enhancements (#1594) Bug 1643526 - Attachment comments don't render markdown, but their preview does
…a file instead of SES which caused interruption of email service
…henticating to BMO using OAuth2
This will allow most bug bounty recipients to view the amount of their bounty. It will not show it to reporters if we filed the bug for them, however those are less liekly to be repeat filers.
Member
|
@dylanwh Please DO NOT squash commits like here, it makes bisecting impossible. |
Member
Author
|
Noted! I hope to carve out some time tomorrow to respond to PRs and such |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.