Skip to content

Conversation

malclocke
Copy link
Contributor

@malclocke malclocke commented Mar 23, 2025

These directories are declared as workspaces in the top level package.json and do not need their own package-lock.json.

None of these files have been touched for more than 2 years and they all contain references to outdated package versions with security alerts.

These directories are declared as workspaces in the top level
`package.json` and do not need their own `package-lock.json`.
@malclocke malclocke requested a review from a team March 23, 2025 20:24
Copy link
Contributor

@gchan gchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the build remains green. 11k lines removed, that's a big salmon!

@malclocke malclocke merged commit ad7d1d1 into main Mar 23, 2025
1 check passed
@malclocke malclocke deleted the remove-workspace-directory-package-locks branch March 23, 2025 20:35
@wooly
Copy link
Contributor

wooly commented Mar 23, 2025

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants