[TE-3912] Add support for tagging executions in playwright #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprizal
reviewed
May 26, 2025
playwright/reporter.js
Outdated
| const fileName = this._paths.prefixTestPath(test.location.file); | ||
| const location = [fileName, test.location.line, test.location.column].join(':'); | ||
|
|
||
| const tags = (test.tags || []).reduce((acc, test) => { |
There was a problem hiding this comment.
Have you looked into Test Annotation? It supports key/value-like structure.
There was a problem hiding this comment.
I considered that yep, but felt it was more likely that they were already using the annotations for other stuff than using tags in a particular format. I'd then need to allow for an annotation sentinel that I could use to detect annotations that were meant to be passed through to bk, to avoid ones that weren't being passed through.
wooly
force-pushed
the
wooly/playwright-tag-support
branch
from
9283f11 to
8e2d05a
Compare
wooly
force-pushed
the
wooly/playwright-tag-support
branch
from
8e2d05a to
a6f8066
Compare
nprizal
reviewed
May 28, 2025
| const { test, expect } = require('@playwright/test'); | ||
|
|
||
| test('has title', async ({ page }) => { | ||
| test('has title', { tag: ['@foo:bar'] }, async ({ page }) => { |
There was a problem hiding this comment.
can we make sure it works with multiple tag?
nprizal
reviewed
May 28, 2025
KatieWright26
approved these changes
May 28, 2025
wooly
force-pushed
the
wooly/playwright-tag-support
branch
from
94a1da1 to
7768087
Compare
|
@nprizal @KatieWright26 I've updated the tests and added a small section to the README.md. Could I please have a re-review? TIA! |
KatieWright26
approved these changes
May 29, 2025
wooly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Playwright has the ability to tag tests.
We want to enable execution-level tagging for playwright so that individual executions can be tagged in TE.
This PR adds the ability to specify tags in the form of
@key:valueand have these parsed by TE askey: valuepairs.