Skip to content

Conversation

nprizal
Copy link
Contributor

@nprizal nprizal commented Jan 24, 2023

Description

The tests failed at main branch with the latest node version (19.4.0) in the build pipeline. We need to change the pipeline to use the lts version of node and make sure all tests pass.

Context

Failed build: https://buildkite.com/buildkite/javascript-test-collectors/builds/116#0185e13b-45e3-4922-8107-71f48090c38b

Changes

  • Set node_version to lts version of node (18.13.0)
  • Update the pipeline to use lts version of node

Verification

All tests should pass

@nprizal nprizal self-assigned this Jan 24, 2023
@nprizal nprizal requested a review from blaknite January 24, 2023 03:34
@nprizal nprizal marked this pull request as ready for review January 24, 2023 03:35
Copy link
Member

@blaknite blaknite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea of providing reliable support for the current LTS instead of chasing every new edge release 🙌

@nprizal nprizal merged commit 3e644f9 into main Jan 24, 2023
@nprizal nprizal deleted the pie-1381-upgrade-to-latest-stable-version-of-node branch January 24, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants