Skip to content

Conversation

nprizal
Copy link
Contributor

@nprizal nprizal commented Jan 26, 2023

Description

This PR allows analytics API to be configured when running a javascript collector. However, the env name conflicts with run env for other CI (see doc).

Context

#48 (comment)

Changes

  1. Rename the env variable used to override analytics API URL to BUILDKITE_ANALYTICS_BASE_URL

@nprizal nprizal requested a review from a team January 26, 2023 02:53
@nprizal nprizal force-pushed the pie-1388-rename-buildkite_analytics_url-for branch from 830f5db to 7e28b21 Compare January 26, 2023 02:54
@nprizal nprizal merged commit df1ebb9 into main Jan 26, 2023
@nprizal nprizal deleted the pie-1388-rename-buildkite_analytics_url-for branch January 26, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants