Skip to content

Improve unread indicator detection and add terminal logging #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

Improve unread indicator detection and add terminal logging #11

merged 1 commit into from
Oct 10, 2025

Conversation

@built-by-as
Copy link
Owner

@built-by-as built-by-as commented Oct 10, 2025 •
edited
Loading

Summary

  • Fixed unread indicator detection to only trigger when Claude finishes responding (using >\r\n pattern instead of timer-based detection)
  • Separated terminal ready detection logic for shell initialization vs Claude interactive session completion

Changes

  • terminal-utils.ts: New shared utilities for terminal state detection with isTerminalReady() (shell) and isClaudeSessionReady() (Claude interactive)
  • main.ts: Updated to use isTerminalReady() for shell initialization
  • renderer.ts: Updated unread detection to use isClaudeSessionReady() and removed timer-based detection logic

Test plan

  • Create a new session and verify unread indicator only triggers after Claude finishes responding (not immediately on command submission)
  • Test with multiple sessions to ensure unread detection works correctly for each session
  • Verify terminal initialization still works properly

@built-by-as
Improve unread indicator detection
d19fc88 
- Fix unread indicator to only trigger when Claude finishes responding (using `>\r\n` pattern instead of timer-based detection)
- Separate terminal ready detection logic for shell initialization vs Claude interactive session completion
- Add terminal-utils.ts with `isTerminalReady()` (shell) and `isClaudeSessionReady()` (Claude interactive)
- Update renderer.ts to use `isClaudeSessionReady()` and remove timer-based detection logic
@built-by-as built-by-as merged commit 74bcedf into main Oct 10, 2025
@built-by-as built-by-as deleted the unread-indicator-fix branch October 10, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@built-by-as