Add getCachedBulletRecordProvider to BulletConfig #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaisarma
reviewed
May 11, 2021
| public void merge(Config other) { | ||
| super.merge(other); | ||
| validate(); | ||
| provider = BulletRecordProvider.from(getAs(RECORD_PROVIDER_CLASS_NAME, String.class)); |
Member
There was a problem hiding this comment.
Good catch but it won't fix it if you do config.set(RECORD_PROVIDER_CLASS_NAME, somethingElse) and do getBulletRecordProvider().
I think the best way to fix it would be to make the getBulletRecordProvider do the check (provider == null || !provider.getClass.getName().equals(get(RECORD_PROVIDER_CLASS_NAME)) and init if so?
0aix
changed the title
akshaisarma
reviewed
May 12, 2021
| BulletRecordProvider providerB = config.getCachedBulletRecordProvider(); | ||
|
|
||
| // Uses the same provider | ||
| Assert.assertEquals(providerA, providerB); |
Member
There was a problem hiding this comment.
Do assertSame to be explicit
| // Default record provider is TypedAvroBulletRecordProvider | ||
| Assert.assertTrue(config.getBulletRecordProvider() instanceof TypedAvroBulletRecordProvider); | ||
|
|
||
| config.set(BulletConfig.RECORD_PROVIDER_CLASS_NAME, "com.yahoo.bullet.record.simple.TypedSimpleBulletRecordProvider"); |
Member
There was a problem hiding this comment.
Import and use TypedSimpleBulletRecordProvider.getClass().getName()?
akshaisarma
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.