Conversation
This requires signoff from every single contributor so far
|
(Todo list in a newer comment) I can't add you to reviewers, but could you please approve this PR? Approving this PR means you agree to the re-license, but since this is only adding the LICENSE text proper, that shouldn't be much of an issue. |
|
I can't approve but it looks good to me too |
|
I approve |
1 similar comment
|
I approve |
|
Are you sure you want to make an iOS app GPL? https://github.com/nextcloud/ios/blob/master/COPYING.iOS https://help.nextcloud.com/t/nextcloud-ios-app-open-sourced/5784 |
|
That may actually be a bit of a concern... |
|
What exactly?
…On Sun, 18 Jun 2023 at 09:24, Jonathan de Jong ***@***.***> wrote:
That may actually be a bit of a concern...
—
Reply to this email directly, view it on GitHub
<#171 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMXYGV2PPI4JRX3L5VIVLXL2UMTANCNFSM6AAAAAAZJEYEGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
If anyone has ideas about which other license to use, please share your ideas. The main requirements are:
I bet there are some important points that I forgot (I'm still very sick and can’t think well), so I trust that @ShadowJonathan will fill in any gaps. |
|
Rescinding my approval pending further discussion |
|
If you copy the following into this repository I guess you'll be covered |
|
@lil5 do you think it's ok if i just copy that to the license file? |
|
Im not a lawyer and have zero training in law Sure |
2c6ca0b
|
Added the clause that makes this publishable to the Apple App Store, IANAL, but I think everyone would have to approve of this change, so i'll mention those who approve via comment, and i'll request review to those who do it via review approval; |
|
approved |
|
Approved |
|
LGTM |
westongpt
left a comment
There was a problem hiding this comment.
Holding for comments from @BrooklynMan
2c05805
|
Regarding 2c05805;
This should fundamentally not disqualify the existing reviews up until now. |
BrooklynMan
left a comment
There was a problem hiding this comment.
this is the basic license text required
|
🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡 |
This requires signoff from every single contributor so far