Skip to content

Add proper LICENSE file#171

Merged
BrooklynMan merged 3 commits intomasterfrom
add-license
Jun 22, 2023
Merged

Add proper LICENSE file#171
BrooklynMan merged 3 commits intomasterfrom
add-license

Conversation

@ShadowJonathan
Copy link
Copy Markdown
Collaborator

This requires signoff from every single contributor so far

This requires signoff from every single contributor so far
buresdv
buresdv previously approved these changes Jun 16, 2023
Copy link
Copy Markdown
Contributor

@buresdv buresdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ShadowJonathan
Copy link
Copy Markdown
Collaborator Author

ShadowJonathan commented Jun 16, 2023

(Todo list in a newer comment)

I can't add you to reviewers, but could you please approve this PR?

Approving this PR means you agree to the re-license, but since this is only adding the LICENSE text proper, that shouldn't be much of an issue.

sebj
sebj previously approved these changes Jun 16, 2023
@noloman
Copy link
Copy Markdown
Contributor

noloman commented Jun 16, 2023

I can't approve but it looks good to me too

@EricBAndrews
Copy link
Copy Markdown
Member

I approve

1 similar comment
@samalone
Copy link
Copy Markdown
Contributor

I approve

mormaer
mormaer previously approved these changes Jun 16, 2023
westongpt
westongpt previously approved these changes Jun 16, 2023
@lil5
Copy link
Copy Markdown
Contributor

lil5 commented Jun 18, 2023

Are you sure you want to make an iOS app GPL?
Last time I checked even Nextcloud iOS has a special clause to allow itself on the Apple Store. #172

https://github.com/nextcloud/ios/blob/master/COPYING.iOS

https://help.nextcloud.com/t/nextcloud-ios-app-open-sourced/5784

@ShadowJonathan
Copy link
Copy Markdown
Collaborator Author

That may actually be a bit of a concern...

@noloman
Copy link
Copy Markdown
Contributor

noloman commented Jun 18, 2023 via email

@buresdv
Copy link
Copy Markdown
Contributor

buresdv commented Jun 18, 2023

If anyone has ideas about which other license to use, please share your ideas.

The main requirements are:

  • The app's source is available to the public, and anyone can change it in order to improve the app. They can also contribute their code and compile the app themselves, and use these modified versions for their personal use.
  • Nobody but us can make money from the app or any derivates of it (covered by Commons Clause).
  • We CAN make money from the app.
  • The app can be published to the App Store.
  • Any modified versions have to keep the original license. In other words, someone can’t just come along, remove the part about them being banned from making money from it, and then make money from it.

I bet there are some important points that I forgot (I'm still very sick and can’t think well), so I trust that @ShadowJonathan will fill in any gaps.

@EricBAndrews
Copy link
Copy Markdown
Member

Rescinding my approval pending further discussion

@lil5
Copy link
Copy Markdown
Contributor

lil5 commented Jun 21, 2023

If you copy the following into this repository I guess you'll be covered

The Mlem iOS developers are aware that the terms of service that
apply to apps distributed via Apple's App Store services may conflict
with rights granted under the Mlem iOS license, the "GNU GPLv3 amended by the Commons Clause v1". We have committed not to pursue any license
violation that results solely from the conflict between the "GNU GPLv3 amended by the Commons Clause v1"
or any later version and the Apple App Store terms of service.

@ShadowJonathan
Copy link
Copy Markdown
Collaborator Author

@lil5 do you think it's ok if i just copy that to the license file?

@lil5
Copy link
Copy Markdown
Contributor

lil5 commented Jun 21, 2023

Im not a lawyer and have zero training in law

Sure

@ShadowJonathan ShadowJonathan dismissed stale reviews from westongpt, mormaer, sebj, and buresdv via 2c6ca0b June 21, 2023 09:20
@ShadowJonathan
Copy link
Copy Markdown
Collaborator Author

ShadowJonathan commented Jun 21, 2023

Added the clause that makes this publishable to the Apple App Store, IANAL, but I think everyone would have to approve of this change, so i'll mention those who approve via comment, and i'll request review to those who do it via review approval;

@ShadowJonathan ShadowJonathan requested review from lil5 and sebj June 21, 2023 09:22
@noloman
Copy link
Copy Markdown
Contributor

noloman commented Jun 21, 2023

approved

sebj
sebj previously approved these changes Jun 21, 2023
buresdv
buresdv previously approved these changes Jun 21, 2023
@EricBAndrews
Copy link
Copy Markdown
Member

Approved

mormaer
mormaer previously approved these changes Jun 21, 2023
@JakeShirley
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Collaborator

@westongpt westongpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding for comments from @BrooklynMan

westongpt
westongpt previously approved these changes Jun 22, 2023
@ShadowJonathan ShadowJonathan dismissed stale reviews from westongpt, mormaer, buresdv, and sebj via 2c05805 June 22, 2023 16:37
@ShadowJonathan
Copy link
Copy Markdown
Collaborator Author

ShadowJonathan commented Jun 22, 2023

Regarding 2c05805;

  • Added full text of the GPL 3 license
  • Changed the licensor name from David to The Mlem Group
  • Added some seperators between the clauses

This should fundamentally not disqualify the existing reviews up until now.

@BrooklynMan
Copy link
Copy Markdown
Contributor

BrooklynMan commented Jun 22, 2023

added GPL 3.0 license file in PR #228

added Common Clause 1.0 with App Name and Org Info in PR #229

@BrooklynMan BrooklynMan reopened this Jun 22, 2023
Copy link
Copy Markdown
Contributor

@BrooklynMan BrooklynMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the basic license text required

@BrooklynMan BrooklynMan merged commit 6197440 into master Jun 22, 2023
@lil5
Copy link
Copy Markdown
Contributor

lil5 commented Jun 23, 2023

🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡🤡

@BrooklynMan BrooklynMan deleted the add-license branch June 24, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.