Skip to content

Conversation

@deirdreg
Copy link

@deirdreg deirdreg commented Oct 8, 2015

Query string parameters with the same key are now stored as an array in the queryParameters dictionary instead of being overwritten with the next value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space tabs 😉

@deirdreg
Copy link
Author

deirdreg commented Oct 8, 2015

Updated to use 4 space tabs

@chrismaddern
Copy link
Contributor

Hey @deirdreg - this is definitely something we want to support, a couple outstanding issues:

  1. It'd be great to see a test to know that it doesn't regress.
  2. Currently it won't support create DPLDeepLink objects with array parameters (https://github.com/myfitnesspal/DeepLinkKit/blob/develop/DeepLinkKit/Categories/NSString%2BDPLQuery.m#L9) - i.e. initWithURL: and url are no longer symmetrical.

@wessmith
Copy link
Member

@deirdreg Do you have interest in completing this? If so, the PR should be updated with the latest from master, support for serializing array values back into query params, and tests to support the changes. Thanks!

@wessmith wessmith closed this Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants