-
Notifications
You must be signed in to change notification settings - Fork 122
remove Python2 comptability code #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kingbuzzman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tristanlatr while removing mock would be a good add. This PR I say is ready to be merged
|
Most of my changes were picked up in other commits/ways. There's now here very little left. |
|
Small commits are better than large commits 😉 This is great! @bw2 / @tristanlatr can you authorize this PR to run CI. And if it passes... merge it? This PR is 2 years old 🤦♂️ |
|
@a-detiste can you resolve your conflicts? |
|
@a-detiste thank you. |
|
@a-detiste im so sorry, can you merge again? The merge of this PR really caused a lot of casualties 😅 -- it wasnt squashed and i kept syncing with master and fixing conflicts as new changes kept coming in.. and well it thinks i changed everything 😇 |
|
@kingbuzzman we are down to one line now. In my eye the addition of https://wiki.debian.org/Python/Backports But that should be handled in another PR |
Oh right, It was me back in May... before I even saw your PR 😇
Kinda.. not really, since this is what is used now...
Agreed. |
|
sorry for missing this earlier. It looks like the changes here have been merged via other PRs so am going to close this one. |
This is not factual. There is still a single line that needs to be removed (this is master) |
|
@bw2 may i suggest you authorize this PR to run the CI, if everything passes, it means mock is truly not needed, and thus this can be merged. Otherwise it can remain closed. |
|
yes please |
No description provided.