Skip to content

Conversation

@a-detiste
Copy link

No description provided.

Copy link
Contributor

@kingbuzzman kingbuzzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tristanlatr while removing mock would be a good add. This PR I say is ready to be merged

@a-detiste
Copy link
Author

Most of my changes were picked up in other commits/ways. There's now here very little left.

@kingbuzzman
Copy link
Contributor

kingbuzzman commented Jun 16, 2025

Small commits are better than large commits 😉

This is great!

@bw2 / @tristanlatr can you authorize this PR to run CI. And if it passes... merge it? This PR is 2 years old 🤦‍♂️

@kingbuzzman
Copy link
Contributor

@a-detiste can you resolve your conflicts?

@kingbuzzman
Copy link
Contributor

@a-detiste thank you.
@bw2 gentle ping.

@kingbuzzman
Copy link
Contributor

kingbuzzman commented Jul 3, 2025

@a-detiste im so sorry, can you merge again? The merge of this PR really caused a lot of casualties 😅 -- it wasnt squashed and i kept syncing with master and fixing conflicts as new changes kept coming in.. and well it thinks i changed everything 😇

@a-detiste
Copy link
Author

@kingbuzzman we are down to one line now.

In my eye the addition of toml dependency is a regression.

https://wiki.debian.org/Python/Backports

But that should be handled in another PR

@kingbuzzman
Copy link
Contributor

kingbuzzman commented Jul 4, 2025

we are down to one line now.

Oh right, It was me back in May... before I even saw your PR 😇

In my eye the addition of toml dependency is a regression.

Kinda.. not really, since this is what is used now...

But that should be handled in another PR

Agreed.

@bw2
Copy link
Owner

bw2 commented Aug 1, 2025

sorry for missing this earlier. It looks like the changes here have been merged via other PRs so am going to close this one.

@bw2 bw2 closed this Aug 1, 2025
@kingbuzzman
Copy link
Contributor

kingbuzzman commented Aug 2, 2025

It looks like the changes here have been merged via other PRs

This is not factual. There is still a single line that needs to be removed (this is master)

@kingbuzzman
Copy link
Contributor

@bw2 may i suggest you authorize this PR to run the CI, if everything passes, it means mock is truly not needed, and thus this can be merged. Otherwise it can remain closed.

@a-detiste
Copy link
Author

yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants