Skip to content

Conversation

@tomash
Copy link

@tomash tomash commented Apr 18, 2025

Context: on Heroku Key-Value addon (Valkey fork of Redis), they use TLS but with a self-signed certificate, as described here:

This PR adds REDIS_SSL_VERIFY environment variable to make it work without patching Pubsubstub's class in-application.

A similar PR is coming to shipit-engine. EDIT: Shopify/shipit-engine#1397

No test coverage because no existing spec covers Redis connection, should I add some?

@tomash
Copy link
Author

tomash commented Apr 18, 2025

I have signed the CLA!

@byroot
Copy link
Owner

byroot commented Apr 19, 2025

There is a million option like this you may need. Any reason why the redis= method doesn't work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants