fix: separate folder component path use #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when attempting to call `componentize()` on a with a `sourcePath` in a different directory, the call to Wizer would be generated with the incorrect *relative* path (path prefix stripping). This commit ensure that when Wizer is called with path prefix stripping, the path to the mapped file is correct.
tschneidereit
approved these changes
Oct 7, 2025
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Thank you for fixing this. I've never been too happy with how I implemented the path resolution changes here a while back, and this bug makes me even less happy with it
Contributor
Author
|
Yeah I was "lucky" to run into it, I think it's not a problem for most people who are using componentize-js, as most are still using the old style arguments, I think! |
Contributor
Author
|
Hey so I think there might be a problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when attempting to call
componentize()on a with asourcePathin a different directory, the call to Wizer would be generated with the incorrect relative path (path prefix stripping).This commit ensure that when Wizer is called with path prefix stripping, the path to the mapped file is correct.