[fix] Update to use cargo-component 0.10.1 deps in tutorial #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
https://github.com/bytecodealliance/cargo-component/blob/v0.10.1/example/src/lib.rs#L23C1-L23C53 Forgot this - so we now have no errors 😁 |
Contributor
Author
|
Also curious if https://github.com/bytecodealliance/cargo-component/blob/v0.10.1/example/Cargo-component.lock is something that could be added, if that is now working? Some way to warn an incompatible version of cargo component is used at least? |
rylev
approved these changes
Mar 19, 2024
kate-goldenring
approved these changes
Mar 19, 2024
Collaborator
|
Thank you @nukemandan for picking this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/bytecodealliance/cargo-component/blob/v0.10.1/example/Cargo.toml#L10-L11 for the present requirements, addresses https://bytecodealliance.zulipchat.com/#narrow/stream/206238-general/topic/Tutorial.20issues.20in.20Rust/near/427608845
Note: This does indeed work as instructed on the README, but every build yields validation errors. Happy to fix those before merging if given a hit as to why 🙏 ... small chance this is a bug with cargo component?