update and fix examples #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier commit which updated various dependencies (most notably, Wasmtime) unmasked a bug in `add_wasi_and_stubs` such that we were overwriting the host functions added by `wasmtime-wasi` with trapping stubs. This wasn't a problem previously because there was only one version of WASIp2: 0.2.0. Now that we have 0.2.1, 0.2.2, etc., with corresponding support in Wasmtime, we need to be a bit more careful. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier commit which updated various dependencies (most notably, Wasmtime) unmasked a bug in
add_wasi_and_stubssuch that we were overwriting the host functions added bywasmtime-wasiwith trapping stubs. This wasn't a problem previously because there was only one version of WASIp2: 0.2.0. Now that we have 0.2.1, 0.2.2, etc., with corresponding support in Wasmtime, we need to be a bit more careful.