Skip to content

feat: add support for multiple wit paths #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

feat: add support for multiple wit paths #165

merged 1 commit into from
Sep 29, 2025

Conversation

HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Sep 22, 2025

Hello, this PR just adds support for multiple -d (--wit-path) like wit-bindgen.

# Assume that the last WIT directory "./wit" has a world named "my_world"
componentize-py \
    -d "./wit/core" \
    -d "./wit/proto" \
    -d "./wit" \
    --world my_world --world-module my_world \
    componentize --stub-wasi bindgen

dicej
dicej approved these changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

src/command.rs
/// File or directory containing WIT document(s)
#[arg(short = 'd', long)]
pub wit_path: Option<PathBuf>,
pub wit_path: Vec<PathBuf>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the doc comment for this field to indicate that it may be specified more than once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your comment! I added to the comment that it accepts duplicate arguments, along with an example.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HoKim98
feat: add support for multiple wit paths
324fc03 
Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
@HoKim98 HoKim98 force-pushed the feat/multiple-wit-paths branch from b3158f5 to 324fc03 Compare September 23, 2025 08:43
@dicej dicej merged commit 324fc03 into bytecodealliance:main Sep 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dicej dicej dicej approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HoKim98 @dicej