Reorganize sockopts code and add several more socket options #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of copying all the Reference URLs for each sockopt function, factor common links out into the module-level documentation.
Implement TCP_USER_TIMEOUT, IP_TOS, IPV6_RECVTCLASS, IP_RECVTOS, and IP_ADD_SOURCE_MEMBERSHIP.
Add `*_ifindex` variations of `IP_ADD_MEMBERSHIP` and `IP_DROP_MEMBERSHIP`, and add `IP_DROP_SOURCE_MEMBERSHIP`.
Reorganize the sockopt test so that socket and tcp options are consistently tested on both ipv4 and ipv6 sockets, and add new tests for the new socket options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize the sockopts code:
sockoptmodules out of the syscalls.rs files into their own filesas _casting needed.And, implement several more sockopt functions:
*_ifindexvariations ofIP_ADD_MEMBERSHIPandIP_DROP_MEMBERSHIPIP_DROP_SOURCE_MEMBERSHIP,TCP_USER_TIMEOUT,IP_TOS,IPV6_RECVTCLASS,IP_RECVTOS,IP_ADD_SOURCE_MEMBERSHIP, andSO_OOBINLINE.