chore: add a test and remove unused variables

Author: oyyd

__test__/seqpacket.spec.ts

@@ -599,6 +599,37 @@ if (!kIsDarwin) {
         autoClose: false,
       })
     });
+
+    it('should emit "error" and "close" in sockets when we write after remote sockets closed', async () => {
+      await createTestPair(async (args) => {
+        const { client, server, socket } = args;
+        const { p: pError, resolve: resolveError } = createDefer();
+        const { p: pClose, resolve: resolveClose } = createDefer();
+        const { p: pCb, resolve: resolveCb } = createDefer();
+
+        client.on('error', () => {
+          resolveError();
+        })
+
+        client.on('close', () => {
+          resolveClose();
+        })
+
+        socket.destroy();
+
+        // TODO should callback get called when sockets get closed?
+        client.write(Buffer.alloc(10), 0, 10);
+        // client.write(Buffer.alloc(10), 0, 10, () => {
+        //   resolveCb();
+        // });
+
+        // await pCb;
+        await pError;
+        await pClose;
+
+        server.close();
+      });
+    });
   });
 } else {
   describe('seqpacket', () => {

js/seqpacket.ts

@@ -222,7 +222,7 @@ export class SeqpacketSocket extends EventEmitter {
   }
 
   /**
-   * Sends data on the socket.
+   * Sends data on the socket. The `cb` is called when data is written to operating system.
    * @param buf
    * @param offset
    * @param length

src/seqpacket.rs

@@ -4,7 +4,7 @@ use std::os::raw::c_int;
 
 use crate::socket::{self, get_loop, sockaddr_from_string, Emitter, HandleData, UvRefence};
 use crate::util::{
-  addr_to_string, buf_into_vec, check_emit, error, get_err, resolve_libc_err, resolve_uv_err,
+  addr_to_string, buf_into_vec, error, get_err, resolve_libc_err, resolve_uv_err,
   set_clo_exec, set_non_block, socket_addr_to_string, uv_err_msg,
 };
 use libc::{sockaddr, sockaddr_un, EAGAIN, EINTR, EINVAL, ENOBUFS, EWOULDBLOCK};

src/socket.rs

@@ -4,7 +4,7 @@ use std::str::FromStr;
 
 use crate::util::{error, get_err, resolve_libc_err, resolve_uv_err};
 use libc::{c_void, sockaddr_storage, sockaddr_un};
-use napi::{Env, JsFunction, JsNumber, JsObject, JsString, JsUnknown, Ref, Result, bindgen_prelude::FromNapiValue, NapiValue};
+use napi::{Env, JsFunction, JsNumber, JsObject, JsString, JsUnknown, Ref, Result, bindgen_prelude::FromNapiValue};
 use uv_sys::sys;
 
 pub(crate) fn get_loop(env: &Env) -> Result<*mut sys::uv_loop_t> {