Skip to content

Conversation

@didi9
Copy link
Contributor

@didi9 didi9 commented Sep 18, 2020

This change is Reviewable

@didi9 didi9 requested a review from romrell4 September 18, 2020 23:49
Copy link
Contributor Author

@didi9 didi9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @romrell4)

a discussion (no related file):
Not sure if this is exactly the reason, but dining-account-lambda-v2 points to this repo, and it's getting an error about terraform version not being able to be used/matching tf_version: '0.13.1' (which is in the ci.yml). Or is there a different reason why that would be occurring?


Copy link
Contributor

@romrell4 romrell4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @didi9)

a discussion (no related file):
This looks good. Do you know how to release a new version?


Copy link
Contributor Author

@didi9 didi9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @romrell4)

a discussion (no related file):

Previously, romrell4 (Eric Romrell) wrote…

This looks good. Do you know how to release a new version?

I don't


Copy link
Contributor

@romrell4 romrell4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@romrell4 romrell4 merged commit dea0142 into master Sep 21, 2020
@romrell4 romrell4 deleted the hotfix/acsversion-1 branch September 21, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants