chore(worker): add unit test for decision iterator #1035
Merged
+309
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
shijiesheng
requested review from
abhishekj720,
demirkayaender,
dkrotx,
natemort and
taylanisikdemir
as code owners
shijiesheng
added a commit
to cadence-workflow/cadence-python-client
that referenced
this pull request
Nov 13, 2025
<!-- Describe what has changed in this PR --> **What changed?** * re-implementing the batching logic <!-- Tell your future self why have you made these changes --> **Why?** current implementation has problems and is based off java SDK with confusing naming. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Unit Test that matches java SDK cadence-workflow/cadence-java-client#1035 <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** --------- Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
natemort
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
additional test to show case how decisions are processed in batches.
Why?
So the same test scenarios could be shared by other SDKs.
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes