feat(worker): return workflow completed result on decision processing #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
shijiesheng
commented
Nov 20, 2025
| return self._replay_current_time_milliseconds | ||
|
|
||
| @contextmanager | ||
| def _activate(self) -> Iterator["Context"]: |
Member
Author
There was a problem hiding this comment.
override so I could steal the activated context rather than exposed WorkflowContext. Maybe this is not necessary but I'm trying to avoid direct access to self._context inside WorkflowEngine.
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
natemort
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
WorkflowEngineinside of theWorkflowInstance(A similar implementation of ReplayWorkflow in javaWhy?
Current processing doesn't return workflow completion result
How did you test it?
WIP Unit Test
Potential risks
Release notes
Documentation Changes