Switch to a custom Github-Api module

[carterm]

The github-api module is causing many exceptions related to "Cannot read property 'status' of undefined" when there is a fetch issue. Now that we are using tree updates only it would be easy to switch back to a custom module that doesn't need all the other github-api features.

This would incorporate all the features in the current gitTreeCommon module, that is used by multiple projects.

New module features

• Take content map (filename + content) and compare it with a GitHub project. Create a commit that updates the project.
• Option to include the commits in a PR
• Option to add assignees to the PR
• Uses the GitHub hashing algorithm to improve the ability to determine binary file changes and prevent unnecessary content uploads.

@cagov\github-sync ?

For custom REST examples, use our old GitHub API connector here

[aaronhans]

Makes sense, glad we tried the github module, shame it isn't well supported

[carterm]

Latest issue...
github-tools/github#439

[carterm]

The new github module will focus on tree updates, and only support the github api functions that we use on a regular basis. Considering names for a new repo. cagov/github-connector

[chachasikes]

Any updates on this?

[chachasikes]

@carterm - I have a couple of questions:
I see the thread on github-tools.

I've handled a similar issue before, and introduced a fetch timeout (on our end).
The issue from github-tools is requesting that they handle network detection, which would be nice - but it's also something we can do.

Q: can you share the lines of code you are proposing to replace (so we can all see them?)

I know you were just asking about what to name the module. It's helpful to see the code. Not sure it needs to be a module yet.

[carterm]

This would be a replacement for all references to github-api.

[chachasikes]

Ah.

[carterm]

This would incorporate all the features in the current gitTreeCommon module, that is used by multiple projects.
https://github.com/cagov/wordpress-to-github/blob/main/wordpress-to-github/gitTreeCommon/index.js

[chachasikes]

(context: Carter is asking us in Slack about what to name a module.)

https://github.com/github-tools/github - "provides a minimal higher-level wrapper around Github's API."

So you are talking about parsing data from the github-api for this module for wordpress-to-github.

To name it, I would look through the code you wrote, & share with us a bullet pointed list of the main features that are going to go into this new module. Then we can name it better.

For example:

• Get github tree data and check for recent commits
• Process sha to see if we need to create a new pull request.

What else?

[carterm]

• Push commits
• Push commits as Pull request
• Add issue assignees
• get commit reports from actions that can be used for logging

[carterm]

Take a list of content -> compare content to GitHub -> make updates where needed -> list what was changed

[chachasikes]

Great - so trying to come up with some names for the features you have described:

(brainstorming)

• github-content-api-pr
• github-pr-from-content-api
• github-headless-diffs
• github-content-diff
• github-content-api-diff

PR's are an important part of this right?
Also - would this module be useful to the data pipelines?