Skip to content

Redacting "code=" from notify post #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carterm merged 6 commits into from
Nov 8, 2021
Merged

Redacting "code=" from notify post #95

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fde5b8e
cleaning out debug info
carterm Nov 1, 2021
7629920
function code redactions for full output
carterm Nov 1, 2021
f377531
debug channel fix
carterm Nov 1, 2021
372af87
debug channel fix
carterm Nov 1, 2021
c15004d
Still full details
carterm Nov 1, 2021
d811d96
optional value chain
carterm Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions WordpressSyncHttpTrigger/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const gitHubCredentials = {

/**
* @param {{executionContext:{functionName:string},res:Response}} context
* @param {{method:string,headers:{"user-agent":string},query:{},params:{},body:GitHubTarget}} req
* @param {{method:string,headers:{"user-agent":string},query?:{code?:string},params:{},body:{slug?:string,trigger?:string}}} req
*/
module.exports = async function (context, req) {
const appName = context.executionContext?.functionName;
Expand All @@ -42,8 +42,8 @@ module.exports = async function (context, req) {

let slackPostTS = "";

const TriggerName = req.body["trigger"] || "(Trigger)";
const SlugName = req.body["slug"] || "(slug)";
const TriggerName = req.body?.trigger || "(Trigger)";
const SlugName = req.body?.slug || "(slug)";
slackPostTS = (
await (
await slackBotChatPost(
Expand All @@ -52,10 +52,16 @@ module.exports = async function (context, req) {
)
).json()
).ts;
//clean out "code" value display
const redactedOutput = JSON.stringify(req, null, 2).replace(
new RegExp(req.query.code, "g"),
`${req.query?.code?.substring(0, 3)}[...]`
);

await slackBotReplyPost(
debugChannel,
slackPostTS,
`\n\n*Full Details*\n\`\`\`${JSON.stringify(req, null, 2)}\`\`\``
`\n\n*Full Details*\n\`\`\`${redactedOutput}\`\`\``
);

//Find endpoints that match the requestor
Expand Down