Skip to content

Update SoundHelper #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 4, 2025
Merged

Update SoundHelper #139

merged 5 commits into from
May 4, 2025

Conversation

@xoascf
Copy link
Contributor

@xoascf xoascf commented May 1, 2025 •
edited
Loading

  • Used SND enumeration with documentation for sound flag values.
  • Changed error logging to debug logging for missing sound files or registry keys, aligning with a less intrusive logging approach (the .log file was sometimes modified just after playing a notification before this).
  • Added a new PlaySystemSound(string alias) method to play system sounds by alias.
  • Upgraded LangVersion to 12 for ManagedShell.Common: I wrote most of the code on November 7, 2022, and I'm surprised that the project is still using an old language version.

@xoascf xoascf changed the title Sound develop Update SoundHelper May 1, 2025
dremin
dremin approved these changes May 4, 2025
View reviewed changes
Copy link
Collaborator

@dremin dremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dremin dremin merged commit cf7405d into cairoshell:master May 4, 2025
1 check passed
@xoascf xoascf deleted the sound-develop branch May 4, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dremin dremin dremin approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xoascf @dremin