Skip to content

Use xpx.quantile instead of _weighted_percentile or np.quantile/np.percentile #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 31 commits into
base: update_xpx
Choose a base branch
from
Draft

Use xpx.quantile instead of _weighted_percentile or np.quantile/np.percentile #3

wants to merge 31 commits into from

Conversation

@cakedev0
Copy link
Owner

No description provided.

cakedev0 and others added 30 commits September 28, 2025 14:09
@cakedev0
implem done; clean-up & comments todo
b0f8bdf
@cakedev0
conform to array-API
2140c82
@cakedev0
cleanup
84c0240
@cakedev0
comments; docstring; cleanups
7822673
@cakedev0
swap functions order for easier diff
c82c75f
@cakedev0
use new signature where useful
f6f877c
@cakedev0
update docstring for new signature
cad8614
@cakedev0
adapt fully to array-API
7f5d47f
@cakedev0
fix array API compat
649b271
@cakedev0
another array API fix: TypeError: object of type 'Array' has no len()
cda231c
@cakedev0
more array-API fixes; tested locally; but I cant test everything I do…
9c4a5ad 
…nt have a nvidia-GPU
@cakedev0
tmp: old for benchmark
4ea221e
@ogrisel
Merge branch 'main' into optim-weighted-percentile
837c287
@cakedev0
Merge branch 'optim-weighted-percentile' of github.com:cakedev0/sciki…
6194d15 
…t-learn into optim-weighted-percentile
@cakedev0
Merge remote-tracking branch 'upstream/main' into optim-weighted-perc…
f14eb58 
…entile
@cakedev0
remove comment about floating dtype
f96d334
@cakedev0 @ogrisel
Fix device error
013725d 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@cakedev0
mitigate perf loss with d>>1
7b9e50b
@cakedev0
Merge branch 'optim-weighted-percentile' of github.com:cakedev0/sciki…
1407248 
…t-learn into optim-weighted-percentile
@cakedev0
Merge remote-tracking branch 'upstream/main' into optim-weighted-perc…
4a8b9df 
…entile
@cakedev0
minor fix for average
35f6d8d
@cakedev0
WIP: inner func handles 2D but only 1 quantile
fd8b2c9
@cakedev0
restore back prev implem. and loop to compute multiple percentiles wi…
d59abf5 
…th only one sort/cumsum
@cakedev0
Merge branch 'main' into optim-weighted-percentile
357c337
@cakedev0
Merge remote-tracking branch 'upstream/main' into optim-weighted-perc…
c1fbcdb 
…entile
@cakedev0
Merge branch 'optim-weighted-percentile' into exp/use_xpx_quantile
cd45b94
@cakedev0
using xpx.quantile everywhere
e327b37
@cakedev0
wip
de9b63c
@cakedev0
wip
89e6503
@cakedev0
fixed backward compat test
202430c
@github-actions
Copy link

github-actions bot commented Oct 26, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 84472cf. Link to the linter CI: here

@cakedev0 cakedev0 changed the title Exp/use xpx quantile Use xpx.quantile instead of _weighted_percentile or np.quantile/np.percentile Oct 26, 2025
@cakedev0 cakedev0 mentioned this pull request Oct 26, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cakedev0 @ogrisel