-
Notifications
You must be signed in to change notification settings - Fork 2.6k
more useful as copy pastable #3791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the templates section to include the default formats, which makes it so that you can copy and paste these easier when making customizations.
| * ``textarea`` {{name}}, {{attrs}}, {{value}} | ||
| A list of the default templates, their default format and the variables they expect are: | ||
|
|
||
| * ``button`` : ``<button{{attrs}}>{{text}}</button>`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this make it much easier for the default templates and docs to get out of sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an FYI... they were out of sync when I made this edit. (I think there
were like two templates missing). So no, I don't think it will be "easier"
to get of sync, because it's already easy :)
Thank you,
Did you know, it takes longer to reply to an email than to write one.
Stop the downward spiral. Read the email charter
http://www.emailcharter.org/.
Richard Kersey
On Thu, Mar 3, 2016 at 2:38 PM, Mark Story notifications@github.com wrote:
In en/views/helpers/form.rst
#3791 (comment):-*
inputContainerError{{type}}, {{required}}, {{content}}, {{error}}
-*inputSubmit{{type}}, {{attrs}}
-*label{{attrs}}, {{text}}, {{hidden}}, {{input}}
-*nestingLabel{{hidden}}, {{attrs}}, {{input}}, {{text}}
-*legend{{text}}
-*option{{value}}, {{attrs}}, {{text}}
-*optgroup{{label}}, {{attrs}}, {{content}}
-*radio{{name}}, {{value}}, {{attrs}}
-*radioWrapper{{input}}, {{label}}
-*select{{name}}, {{attrs}}, {{content}}
-*selectMultiple{{name}}, {{attrs}}, {{content}}
-*submitContainer{{content}}
-*textarea{{name}}, {{attrs}}, {{value}}
+A list of the default templates, their default format and the variables they expect are:
+
+*button:<button{{attrs}}>{{text}}</button>Doesn't this make it much easier for the default templates and docs to get
out of sync?—
Reply to this email directly or view it on GitHub
https://github.com/cakephp/docs/pull/3791/files#r54934965.
|
How about we just lnk to http://api.cakephp.org/3.2/class-Cake.View.Helper.FormHelper.html#%24_defaultConfig instead? This way we don't have to keep it up to date. |
|
Can you submit a PR for that? IMO much better solution. Thank you, Did you know, it takes longer to reply to an email than to write one. http://www.emailcharter.org/.Richard Kersey On Fri, Mar 4, 2016 at 5:43 AM, Marc Würth notifications@github.com wrote:
|
Updated the templates section to include the default formats, which makes it so that you can copy and paste these easier when making customizations.