update references to setConfig #4994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
May 26, 2017
| public function beforeFilter(Event $event) | ||
| { | ||
| $this->Security->config('blackHoleCallback', 'blackhole'); | ||
| $this->Security->setConfig('blackHoleCallback', 'blackhole'); |
Member
There was a problem hiding this comment.
We should leave a comment that before 3.4.0 people should use config().
ravage84
requested changes
May 26, 2017
Member
ravage84
left a comment
ravage84
left a comment
There was a problem hiding this comment.
Agree with @markstory's comment https://github.com/cakephp/docs/pull/4994/files#r118618690
Member
Author
|
fixed, thank you! |
HavokInspiration
added a commit
that referenced
this pull request
Jun 23, 2017
Merged
okinaka
added a commit
to okinaka/docs
that referenced
this pull request
Jun 24, 2017
okinaka
added a commit
to okinaka/docs
that referenced
this pull request
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.