Document standalone paginator. #5040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include an example of usage in View Cells. Refs cakephp/cakephp#10718
| 'scope' => 'favourites' | ||
| ] | ||
| ); | ||
| $this->set('favorites', $results); |
Member
There was a problem hiding this comment.
You used a different spelling of "favorites" on line 237 😄
Member
|
@markstory Looks good except for the minor issue jeremyharris pointed out. Thanks for taking care of docs updation. |
Member
|
I updated to consistently use the US spelling 😛 |
Member
|
Can this be merged or do we wait for FR and JA translations? (Dunno what's the process followed on docs PRs). |
Member
|
No need to wait for translations. |
ravage84
approved these changes
Jun 19, 2017
Member
ravage84
left a comment
ravage84
left a comment
There was a problem hiding this comment.
Fixed some syntax errors, but looks good. Thanks!
HavokInspiration
added a commit
that referenced
this pull request
Jul 4, 2017
okinaka
added a commit
to okinaka/docs
that referenced
this pull request
Aug 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include an example of usage in View Cells. Does this look reasonable @ADmad?
Refs cakephp/cakephp#10718