Add console hook documentation. #5088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add brief documentation on the console() hook. I plan on adding a more holistic section for the application class. Just not sure where to put it just yet. Refs cakephp/cakephp#10716
ravage84
reviewed
Jul 12, 2017
| hook that allows them to have full control over which CLI commands are exposed, | ||
| how they are named and how the shells get their dependencies. Adopting this new | ||
| class requires replacing the contents of your ``bin/cake.php`` file with the | ||
| `following file <https://github.com/cakephp/app/tree/3.next/bin/cake.php>`_. |
Member
There was a problem hiding this comment.
This link would get outdated. Why not set the future one in place already?
Member
Author
There was a problem hiding this comment.
If I use the future link now. It will be broken until the release.
| { | ||
| public function console($commands) | ||
| { | ||
| // Add by classname |
Member
There was a problem hiding this comment.
What ar the impllications of both ways? Which do we recommend and why?
Member
Author
There was a problem hiding this comment.
I find classnames simpler. But DI fans might like to build console commands from a container which lends itself to instances more.
HavokInspiration
added a commit
that referenced
this pull request
Jul 16, 2017
Merged
okinaka
added a commit
to okinaka/docs
that referenced
this pull request
Jul 29, 2017
okinaka
added a commit
to okinaka/docs
that referenced
this pull request
Jul 29, 2017
okinaka
added a commit
to okinaka/docs
that referenced
this pull request
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add brief documentation on the console() hook. I plan on adding a more holistic section for the application class. Just not sure where to put it just yet.
Refs cakephp/cakephp#10716