-
Notifications
You must be signed in to change notification settings - Fork 22
Fix CI errors #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI errors #174
Conversation
17b72c3 to
62ae616
Compare
|
@ADmad i was getting twig compilation errors on prefer-lowest due to old twig version. Added twig-view constraint here to 2.0.2 which requires a higher twig version but maybe we should add this in bake instead?
When i run tests on the bake repo locally with prefer-lowest i get the exact same twig compilation errors. |
|
@josbeir Adding proper constraints for twig to bake itself makes sense. |
composer.json
Outdated
| "psr/log": "^3.0" | ||
| }, | ||
| "require-dev": { | ||
| "cakephp/twig-view": "^2.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josbeir We can remove this now that bake is updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, bake 3.5.x needs cake 5.1 btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. In that case we should bump the Cake constraint for queue too and cut a new minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, but maybe wait with releasing. I'm planning on doing a little bit modernization in the codebase first
No description provided.