Skip to content

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Oct 22, 2025

No description provided.

@josbeir josbeir force-pushed the ci branch 2 times, most recently from 17b72c3 to 62ae616 Compare October 22, 2025 09:41
- Update tests to be compatible with phpunit 11/12
- Implement QueueMananger::configured() to allow easier lookup and thus also teardowns in tests
- Conslidated DebugLogTrait into new QueueTestTrait
- Bump min phpunit to 10.5.32
@josbeir
Copy link
Contributor

josbeir commented Oct 22, 2025

@ADmad i was getting twig compilation errors on prefer-lowest due to old twig version. Added twig-view constraint here to 2.0.2 which requires a higher twig version but maybe we should add this in bake instead?

composer update --prefer-lowest --prefer-dist --prefer-stable

When i run tests on the bake repo locally with prefer-lowest i get the exact same twig compilation errors.

@ADmad
Copy link
Member Author

ADmad commented Oct 22, 2025

@josbeir Adding proper constraints for twig to bake itself makes sense.

composer.json Outdated
"psr/log": "^3.0"
},
"require-dev": {
"cakephp/twig-view": "^2.0.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josbeir We can remove this now that bake is updated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, bake 3.5.x needs cake 5.1 btw

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. In that case we should bump the Cake constraint for queue too and cut a new minor.

Copy link
Contributor

@josbeir josbeir Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but maybe wait with releasing. I'm planning on doing a little bit modernization in the codebase first

@ADmad ADmad merged commit acfc65b into 2.x Oct 23, 2025
9 checks passed
@ADmad ADmad deleted the ci branch October 23, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants