fix: Embed - Non transparent background when color-scheme of embedding document and cal.com iframe don't match by hariombalhara · Pull Request #10033 · calcom/cal.diy

hariombalhara · 2023-07-10T09:36:52Z

What does this PR do?

Before:
https://www.loom.com/share/1890e4eebf41426aaf66d8b4909d0765
After:
https://www.loom.com/share/8b00c41587f2467ab05ef48e4ed523ef

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

See loom

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works

…o fix/new-booker-embed-misc

…and light schemes

vercel · 2023-07-10T09:36:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 2:55pm
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 2:55pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 2:55pm
cal-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 2:55pm

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
dev	⬜️ Ignored (Inspect)		Mar 19, 2024 2:55pm
qa	⬜️ Ignored (Inspect)		Mar 19, 2024 2:55pm
ui	⬜️ Ignored (Inspect)	Visit Preview	Mar 19, 2024 2:55pm

github-actions · 2023-07-10T09:37:07Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-07-10T09:45:02Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-07-10T09:46:42Z

Current Playwright Test Results Summary

✅ 94 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/18/2023 02:13:38pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: df198e4

Started: 07/18/2023 02:11:52pm UTC

⚠️ Flakes

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	1.32% (2) 2 / 152 runs failed over last 7 days	98.03% (149) 149 / 152 runs flaked over last 7 days

View Detailed Build Results

PeerRich · 2023-07-11T08:35:26Z

is this what infisical is experiencing?

alwaysmeticulous · 2023-07-11T08:46:02Z

🤖 Meticulous spotted visual differences in 201 of 432 screens tested: view and approve differences detected.

_{Last updated for commit df198e4. This comment will update as new commits are pushed.}

hariombalhara · 2023-07-12T03:23:53Z

@PeerRich Yes, it's the same issue. But they are experiencing a bigger issue that their CSP policy is blocking our inline styles. Also CSP policy is impacting not just us but Intercom as well.

…e of

…not-working-embed

…misc

hariombalhara · 2023-07-18T11:06:01Z

-    const iframe = this.cal.createIframe({ calLink, queryObject: Cal.getQueryObject(config) });
-    iframe.style.height = "100%";
-    iframe.style.width = "100%";
-    const element =


Renamed element to containerEl

zomars

…g document and cal.com iframe don't match (calcom#10033) ## What does this PR do? Fixes calcom#10032 Before: https://www.loom.com/share/1890e4eebf41426aaf66d8b4909d0765 After: https://www.loom.com/share/8b00c41587f2467ab05ef48e4ed523ef ## Type of change  - Bug fix (non-breaking change which fixes an issue) ## How should this be tested? - See loom ## Mandatory Tasks - [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected. ## Checklist - I haven't added tests that prove my fix is effective or that my feature works

Diwannist · 2025-01-15T10:33:47Z

I get a white background when I have dark theme on.

hariombalhara added 6 commits July 10, 2023 11:03

Consider localhost an invalid org slug always because it has no dot

8a72523

Fix border for booker in embed

09ef628

Merge remote-tracking branch 'origin/fix/localhost-booking-pages' int…

a3ba753

…o fix/new-booker-embed-misc

Add color-scheme example

e6c4d08

Ensure color-scheme of container page and iframe stays same for dark …

1b5245e

…and light schemes

Set color-scheme as soon as possible

117fce1

github-actions Bot added the embed area: embed, widget, react embed label Jul 10, 2023

zomars added the core area: core, team members only label Jul 10, 2023

hariombalhara changed the title ~~Consider localhost an invalid org slug always because it has no dot~~ Embed - Improved color-scheme support Jul 10, 2023

vercel Bot had a problem deploying to Preview – ui July 10, 2023 09:41 Failure

vercel Bot deployed to Preview – api July 10, 2023 09:43 View deployment

vercel Bot deployed to Preview – cal July 10, 2023 09:43 View deployment

Merge branch 'main' into fix/new-booker-embed-misc

024f603

vercel Bot had a problem deploying to Preview – api July 11, 2023 08:39 Failure

vercel Bot deployed to Preview – ui July 11, 2023 08:39 View deployment

vercel Bot deployed to Preview – cal July 11, 2023 08:45 View deployment

hariombalhara added 7 commits July 14, 2023 20:35

Fix theme override not working embed

4e1068d

Remove the functionality to setTheme as thats automatically taken car…

8c9f582

…e of

Add failing test

4b36f6f

Merge remote-tracking branch 'origin/main' into fix/theme-preference-…

9dd75da

…not-working-embed

More fixes

600bed0

Fix tests

d88d17f

Type Fix

3226579

Merge remote-tracking branch 'origin/main' into fix/new-booker-embed-…

823f210

…misc

vercel Bot deployed to Preview – ui July 18, 2023 07:53 View deployment

vercel Bot deployed to Preview – cal-staging July 18, 2023 07:55 View deployment

vercel Bot deployed to Preview – api July 18, 2023 07:55 View deployment

vercel Bot deployed to Preview – cal-demo July 18, 2023 07:56 View deployment

vercel Bot deployed to Preview – cal July 18, 2023 07:56 View deployment

hariombalhara commented Jul 18, 2023

View reviewed changes

hariombalhara added the High priority Created by Linear-GitHub Sync label Jul 18, 2023

Add support to update all namespaces on color-scheme change

d2c30e0

hariombalhara force-pushed the fix/new-booker-embed-misc branch from a5671be to d2c30e0 Compare July 18, 2023 13:50

vercel Bot deployed to Preview – cal July 18, 2023 13:56 View deployment

vercel Bot deployed to Preview – cal-demo July 18, 2023 13:57 View deployment

vercel Bot deployed to Preview – api July 18, 2023 13:58 View deployment

Add comment

df198e4

hariombalhara commented Jul 18, 2023

View reviewed changes

Comment thread packages/embeds/embed-core/src/embed.ts

hariombalhara mentioned this pull request Jul 18, 2023

[CAL-2199] Handle momentary flash of non-transparent background when conflicting color-schemes are there. #10226

Closed

vercel Bot deployed to Preview – cal July 18, 2023 14:07 View deployment

hariombalhara marked this pull request as ready for review July 18, 2023 14:07

hariombalhara requested a review from a team July 18, 2023 14:07

hariombalhara changed the title ~~fix: Embed - Improved color-scheme support to match it with the embedding website.~~ fix: Embed - Non transparent background when color-scheme don't match Jul 18, 2023

vercel Bot deployed to Preview – api July 18, 2023 14:08 View deployment

hariombalhara changed the title ~~fix: Embed - Non transparent background when color-scheme don't match~~ fix: Embed - Non transparent background when color-scheme of embedding document and cal.com iframe don't match Jul 18, 2023

vercel Bot deployed to Preview – cal-demo July 18, 2023 14:08 View deployment

PeerRich requested a review from zomars July 18, 2023 15:28

zomars approved these changes Jul 18, 2023

View reviewed changes

zomars merged commit 11081cb into main Jul 18, 2023

zomars deleted the fix/new-booker-embed-misc branch July 18, 2023 16:46

hariombalhara mentioned this pull request Jul 20, 2023

fix: Momentary flash of non-transparent background with different color-schemes of embed and embedding document #10265

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Embed - Non transparent background when color-scheme of embedding document and cal.com iframe don't match#10033

fix: Embed - Non transparent background when color-scheme of embedding document and cal.com iframe don't match#10033
zomars merged 23 commits intomainfrom
fix/new-booker-embed-misc

hariombalhara commented Jul 10, 2023 •

edited

Loading

Uh oh!

vercel Bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2023 •

edited

Loading

Uh oh!

deploysentinel Bot commented Jul 10, 2023 •

edited

Loading

Test Case Results

Uh oh!

PeerRich commented Jul 11, 2023

Uh oh!

alwaysmeticulous Bot commented Jul 11, 2023 •

edited

Loading

Uh oh!

hariombalhara commented Jul 12, 2023

Uh oh!

hariombalhara Jul 18, 2023

Uh oh!

Uh oh!

zomars left a comment

Uh oh!

Diwannist commented Jan 15, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hariombalhara commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

vercel Bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel Bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Uh oh!

PeerRich commented Jul 11, 2023

Uh oh!

alwaysmeticulous Bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara commented Jul 12, 2023

Uh oh!

hariombalhara Jul 18, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

Diwannist commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hariombalhara commented Jul 10, 2023 •

edited

Loading

vercel Bot commented Jul 10, 2023 •

edited

Loading

github-actions Bot commented Jul 10, 2023 •

edited

Loading

github-actions Bot commented Jul 10, 2023 •

edited

Loading

deploysentinel Bot commented Jul 10, 2023 •

edited

Loading

alwaysmeticulous Bot commented Jul 11, 2023 •

edited

Loading

Diwannist commented Jan 15, 2025 •

edited

Loading