fix: ternary operator with lenght causing 0#10090
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 67 of 259 screens tested: view and approve differences detected. Last updated for commit ce6bdee. This comment will update as new commits are pushed. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 88 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/12/2023 12:16:35pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ce6bdee Started: 07/12/2023 12:14:20pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
0% (0)0 / 42 runsfailed over last 7 days |
11.90% (5)5 / 42 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
3.70% (1)1 / 27 runfailed over last 7 days |
96.30% (26)26 / 27 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
0% (0)0 / 27 runsfailed over last 7 days |
14.81% (4)4 / 27 runsflaked over last 7 days |
|
!! works too and is cleaner 👍 |
|
I think a cleaner approach here is to actually do a strict comparison to 0, |
PSA: dont use
lengthwith&&to prevent trailing 0's